feat(replaceOuter) : Added replaceOuter property to replace the data-loc tag with the remote content or fragment#6
Open
jhaeyaert wants to merge 1 commit into
Conversation
…ith the remote content or fragment
Member
|
This looks good to me. I'll need to check to see if this breaks anything on our end since it changes the default output of the HTML, but I agree with your default as it makes it cleaner. I'll try to test and get this merged as soon as I can and release a new version. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple feature allows to replace the 'data-loc' tag with the remote content or fragment by default. If property is set to 'true', the actual behaviour is adopter (ie : include content into div tag).
That way, the final HTML will be clean of non necessary tags.
Ex :
Let's say that page-header-app is responsible to generate the following header html content :
The page includes the header content using data-loc :
The old way of working will produce :
The new way of working will now produce this cleaned result by default :