Fix macOS DMG build: add exclude_binaries=True to PyInstaller EXE block - #8
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Build macOS (DMG)
Fix macOS DMG build: add exclude_binaries=True to PyInstaller EXE block
Jul 25, 2026
evildevill
marked this pull request as ready for review
July 25, 2026 09:23
There was a problem hiding this comment.
Pull request overview
Fixes the failing “Build macOS (DMG)” GitHub Actions job by adjusting the macOS PyInstaller spec so COLLECT receives an onedir-style output (a directory) rather than a onefile-style output (a single executable file).
Changes:
- Added
exclude_binaries=Trueto the macOSEXE(...)block to keep binaries/data out of the EXE soCOLLECTcan assembledist/PlaylistForge/correctly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Build macOS (DMG)" CI job was failing because
playlistforge.macos.specwas missingexclude_binaries=Truein itsEXEblock, causing PyInstaller to createdist/PlaylistForgeas a self-contained onefile binary. The subsequentCOLLECTstep then failed when it tried to treat that file as a collectible resource directory:Change
packaging/pyinstaller/playlistforge.macos.spec: Addedexclude_binaries=Trueto theEXEblock, matching the pattern already used inplaylistforge.linux.spec. This keeps the EXE stripped of bundled binaries so thatCOLLECTcan assemble them intodist/PlaylistForge/, whichBUNDLEthen wraps into the finalPlaylistForge.app.