fix: req support for pod identity#1189
Open
brentjanderson wants to merge 1 commit intoex-aws:mainfrom
Open
Conversation
The current pod identity implementation provides defaults that are merged into other http options. The Pod identity request defaults include :recv_timeout which is incompatible with Req. By following ex-aws#1095 we can unblock Req adapter users on pod identity implementation. A more robust fix that would also be a breaking change would involve getting the default HTTP options from the adapter itself for various use-cases, and merging those into the implementation.
Author
|
Saw that this is an alternative to #1175 - the approach to each seems mutually exclusive. |
I like this solution better, was not aware we are already doing some renaming for Req, so this approach is more consistent and less intrusive for sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current pod identity implementation provides defaults that are merged into other http options. The Pod identity request defaults include :recv_timeout which is incompatible with Req. By following #1095 we can unblock Req adapter users on pod identity implementation. A more robust fix that would also be a breaking change would involve getting the default HTTP options from the adapter itself for various use-cases, and merging those into the implementation.