fix(request): wrap HTTP adapters with Code.ensure_loaded? for optional deps#1193
Open
ManuzimFerreira wants to merge 1 commit intoex-aws:mainfrom
Open
fix(request): wrap HTTP adapters with Code.ensure_loaded? for optional deps#1193ManuzimFerreira wants to merge 1 commit intoex-aws:mainfrom
ManuzimFerreira wants to merge 1 commit intoex-aws:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users who don't use Req as their HTTP client see this warning during compilation:
Solution
Wrap HTTP client adapter modules with
if Code.ensure_loaded?so they are only defined when the optional dependency is available at compile time.This follows the same pattern used by Tesla for optional adapters.
Changes
lib/ex_aws/request/req.ex- wrapped withif Code.ensure_loaded?(Req)lib/ex_aws/request/hackney.ex- wrapped withif Code.ensure_loaded?(:hackney)for consistency