Add x-amz-checksum headers on put_object#256
Draft
crbelaus wants to merge 2 commits intoex-aws:mainfrom
Draft
Conversation
Contributor
|
Hi @crbelaus. This looks good, thanks! Is it ready to be merged? |
|
Having the hash header in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #244 added support for
x-amz-checksumheaders when using other hash algorithms thanmd5. This pull request adds the relevant header when usingput_objectso new objects will have the appropriate checksum header.This will work automatically as long as you have something like this in your configuration:
Additionally, this pull request also updates the accepted headers for the
head_objectcall so you can get the checksum that was stored in S3 when the object was created. This can be done with the following code: