Open
Conversation
Adds a GitHub Actions workflow that scans PRs and master pushes for hardcoded secrets using TruffleHog. Only verified (live) secrets trigger failures to minimize noise from historical or test credentials. Co-Authored-By: patrick <patrick@exa.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
SEC-38
Why are the changes needed?
A historical Terraform file contained a hardcoded database password. That Terraform path has already been deleted from
master, and the reported RDS cluster does not exist in us-west-2, but the repo did not have CI coverage to catch future committed secrets.What changes were proposed in this pull request?
Adds a GitHub Actions workflow that runs TruffleHog on pull requests and
masterpushes. The scan uses--only-verifiedso CI fails on live, verified credentials while avoiding noise from historical/test strings.How was this patch tested?
git diff --check origin/master...HEADmasterflyteadmin-clusterdoes not exist in AWS RDS us-west-2TruffleHog Secret ScanpassedLabels
security
Setup process
N/A
Screenshots
N/A
Check all the applicable boxes
Related PRs
N/A
Docs link
N/A
Link to Devin session: https://app.devin.ai/sessions/45c81ad103e3473498643cb74c3a8347
Requested by: @pschork