fix(image-spec): enable nix-command and flakes in determinate installer#52
Open
jld-adriano wants to merge 2 commits intopinned-d08a784aefrom
Open
fix(image-spec): enable nix-command and flakes in determinate installer#52jld-adriano wants to merge 2 commits intopinned-d08a784aefrom
jld-adriano wants to merge 2 commits intopinned-d08a784aefrom
Conversation
Pass 'experimental-features = nix-command flakes' via --extra-conf so that the later 'nix run .#docker.copyTo' step works. Without this, newer determinate installers leave nix-command disabled and the build fails with: error: experimental Nix feature 'nix-command' is disabled; add '--extra-experimental-features nix-command' to enable it Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The
NIX_DOCKER_FILE_TEMPLATEinstalls Nix via the Determinate installer and then runsnix run .#docker.copyToto build the image. Newer Determinate installers ship withexperimental-featuresunset by default, so the laternix runfails with:This broke every
nix=TrueImageSpecbuild in CI (see failing jobs on exa-labs/monorepo#30215: ray-test, elastic-multi-to-multi, elastic-multi-to-single, elastic-single-to-multi-node, elastic-single-to-multi-process).What changes were proposed in this pull request?
Pass
--extra-conf "experimental-features = nix-command flakes"to the Determinate installer in the same place as the other--extra-confflags. This writes the setting to/etc/nix/nix.confat install time, so the subsequentnix runhasnix-commandandflakesenabled.Base branch is
pinned-d08a784ae(the commit exa-labs/monorepo currently pins) so the diff is just the one-line addition, isolated from the 19 other commits onmaster.How was this patch tested?
Will be verified end-to-end by re-running the Basic Flyte Feature Tests on exa-labs/monorepo after bumping the flytekit pointer.
Check all the applicable boxes
Link to Devin session: https://app.devin.ai/sessions/98d8186c6d3147738bd209459fcfac5b
Requested by: @jld-adriano