Fix #86: normalize promoted dependent attributes for age realism#103
Closed
DeveshParagiri wants to merge 1 commit intomainfrom
Closed
Fix #86: normalize promoted dependent attributes for age realism#103DeveshParagiri wants to merge 1 commit intomainfrom
DeveshParagiri wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
Superseded by #106 which implements a proper LLM-driven approach for semantic_type classification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Closes #86
Recreated from closed PR #93 (base branch was deleted)
This PR uses fragile keyword matching for attribute type detection:
Problem: Silently fails if LLM names attributes differently:
earning(singular) → ❌ not matchedpay,annual_pay→ ❌ not matcheddiploma,schooling→ ❌ not matchedSuggested fix: Add
semantic_typefield to AttributeSpec for explicit declaration.See full review: #93 (review)