Fix #85: preserve dependent names when promoting to full agents#92
Merged
DeveshParagiri merged 1 commit intomainfrom Feb 17, 2026
Merged
Fix #85: preserve dependent names when promoting to full agents#92DeveshParagiri merged 1 commit intomainfrom
DeveshParagiri merged 1 commit intomainfrom
Conversation
Collaborator
DeveshParagiri
left a comment
There was a problem hiding this comment.
Code Review
Verdict: ✅ Ready to merge
Summary
Minimal 5-line fix that correctly extracts first_name from dependent metadata and preserves last_name from parent household.
Edge Cases Handled
| Case | Handling |
|---|---|
| Dependent has no name | Falls back to sampled name (defensive getattr) |
| Household has no last_name | No override, preserves sampled value |
| Whitespace-only name | .strip() converts to empty, guard prevents assignment |
Code
dep_name = str(getattr(dependent, "name", "")).strip()
if dep_name:
agent["first_name"] = dep_name
if parent.get("last_name"):
agent["last_name"] = parent["last_name"]Tests
Regression test validates promoted dependents have names matching household metadata.
No changes required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Closes #85