Fix #89: make THINK vs SAY divergence observable#96
Closed
RandomOscillations wants to merge 1 commit intocodex/issue-88-macro-feedbackfrom
Closed
Fix #89: make THINK vs SAY divergence observable#96RandomOscillations wants to merge 1 commit intocodex/issue-88-macro-feedbackfrom
RandomOscillations wants to merge 1 commit intocodex/issue-88-macro-feedbackfrom
Conversation
Collaborator
DeveshParagiri
left a comment
There was a problem hiding this comment.
Code Review
Verdict: ✅ Ready to merge
Summary
Makes THINK vs SAY divergence observable by classifying private_thought and public_statement separately in high-fidelity simulations.
Implementation
| Component | Change |
|---|---|
ReasoningResponse |
Added public_position: str | None |
| Classification | Separate calls for private_thought (→position) and public_statement (→public_position) |
| Engine | Uses response.public_position or response.position for DB state |
| meta.json | Now includes fidelity for auditability |
Edge Cases
| Case | Handling |
|---|---|
Empty public_statement |
Returns {}, falls back to position |
| No divergence | public_position equals position |
| Medium/low fidelity | Skips public classification |
Minor Suggestion (non-blocking)
Consider adding a test for empty public_statement edge case to verify fallback works.
No blocking changes required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public_positiontoReasoningResponseso high-fidelity reasoning can carry a separate public stanceprivate_thought(fallback to reasoning), and classify public position frompublic_statementat high fidelityresponse.public_positionin engine state updates (fallback toresponse.position) so divergence persists to DB-visible statefidelityinmeta.jsonfor run auditabilityTesting
Closes #89