Fix #82: audit and standardize logging behavior#98
Closed
RandomOscillations wants to merge 3 commits intomainfrom
Closed
Fix #82: audit and standardize logging behavior#98RandomOscillations wants to merge 3 commits intomainfrom
RandomOscillations wants to merge 3 commits intomainfrom
Conversation
Collaborator
DeveshParagiri
left a comment
There was a problem hiding this comment.
Code Review
Verdict: ✅ Ready to merge
Summary
Standardizes logging practices and adds comprehensive security hardening for sensitive data redaction.
Changes
| Area | Fix |
|---|---|
print() statements |
Replaced with logger.info() in metrics.py, hydrator.py |
| Secret redaction | api_key, token, password, etc. → [REDACTED_SECRET] |
| Text redaction | prompt, content, reasoning, etc. → [REDACTED_TEXT length=N] |
| Long strings | Truncated at 200 chars with ...[truncated] |
| Token counts | Preserved (whitelist) |
| Documentation | New docs/logging-guidelines.md |
Security Analysis
- ✅ Recursive sanitization handles nested structures
- ✅ Broad text markers catch various sensitive fields
- ✅ Preserves useful metadata (token counts, model, IDs)
- ✅ Pass-1 prompt logging now only logs length
Tests
4 tests validate redaction of secrets and text content.
No changes required.
Collaborator
|
Closing - branch was stacked on blocked PRs. Recreated as clean PR from main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
print()paths in network metrics and hydration orchestration with module logger usageapi_key, auth/token-like fields)docs/logging-guidelines.mdto document logging conventions and safety expectationsTesting
Closes #82