Skip to content

The Windows screenshot set lands flat, because shots.ps1 takes no language #4

Description

@anderix

packaging/windows/shots.ps1 takes no language, so the Windows set lands flat and ship refuses it after the runner run has been paid for. The macOS pair does take one.

What was verified, 2026-09-18

  • shots.ps1's whole param block is [switch] $Reference and [string] $OutDir, and its closing call is Take-Shots -Launch ... -OutDir $OutDir -Reference:$Reference with no -Lang.
  • packaging/windows/take-shots.ps1 is ship's generated half and is current. It takes -Lang and makes a locale subdirectory only when it is given one.
  • windows.yml names no languages: for the shared action. apple-silicon.yml passes languages: en de, which is why the Mac lane is right.
  • packaging/sample.de.toml exists, so the German document this lane would open is already here.

What it costs

Answering yes to ship's offer of a fresh Windows set costs a runner run and then refuses the whole msix target: appstore.Read requires one subdirectory per locale, because the locale is half the name the Microsoft Store files a frame under.

What closes it

shots.ps1 takes -Lang and hands it to Take-Shots, and windows.yml passes languages: en de.

Moved from anderix/ship#14 and the Windows half of anderix/ship#8 and #18. ship no longer claims the lane takes two languages: it reads the workflow and says what the workflow asks for.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions