Skip to content

The macOS screenshot driver is a fork of the template and cannot take a German frame #7

Description

@anderix

packaging/macos/screenshot.sh is a fork of ship's template, about 300 lines diverged, and packaging/macos/take-shots.sh is absent.

What was verified, 2026-09-18

odox                       packaging/windows/screenshot.ps1 current
odox                       packaging/windows/take-shots.ps1 current
odox                       packaging/macos/screenshot.sh is the repo's own

The Windows pair are generated and up to date. The macOS driver carries no marker line, so ship sync marks it the repo's own and leaves it alone; take-shots.sh is absent and is not mentioned at all.

It is a fork rather than a different thing. Diffing it against internal/generate/templates/screenshot.sh with the marker line dropped gives about 300 changed lines of the same script: the same window-server probing, the same --click/--double/--type/--key actions, the same refusal on a wrong-sized capture, much of it word for word.

What it costs

It cannot take a German frame — the template's --lang support is not in it — and everything the template has gained since the fork is not here either: the display being raised to 1440x900 before the window is sized, which a hosted runner needs, and now the appearance helper for a light set and a dark one.

What closes it

Take the template: put the marker line in, let ship sync own both files, and move whatever odox actually needs that the template lacks into the repository's own shots.sh, which is the half that is meant to differ.

Held behind the three-products question, since what odox photographs depends on how many products it is.

Moved from anderix/ship#27.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions