The application icon is the glyph alone - #10
Merged
Merged
Conversation
Each application wore the icon of the document it reads: a page with a folded corner, carrying the glyph of what is on it. The page is now the document's alone. An application is drawn twice in `packaging/artwork`, which is where the drawings move to from `linux/icons`, a directory that had never been Linux's: `<app>-document.svg` is that page, unchanged, and `<app>-application.svg` is the glyph off it, grown into the grid the page left and centred on the 64-unit one. Every consumer is pointed at whichever of the two it draws. `make-icons` renders `<app>.ico` and `<app>.icns` from the application drawing and a new `<app>-document.ico` and `<app>-document.icns` from the document one; in the Store assets only `FileTypeLogo` comes from the document, and the tiles, the logos and both listing squares come from the application. `install.ps1` points a ProgId's `DefaultIcon` at the document icon directory and its `ApplicationIcon` at the other, and `uninstall.ps1` removes both. A macOS bundle carries both families, with `CFBundleTypeIconFile` and `UTTypeIconFile` on a `@DOCUMENT_ICON@` placeholder and `CFBundleIconFile` still on `@ICON@`. Linux installs the application drawing into the hicolor theme and leaves a document to shared-mime-info, as it always has. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An application wore the icon of the document it reads. It now wears the glyph
off that page, with the page outline and its folded corner dropped and the
drawing grown into the grid they left. The document icon is unchanged and stays
what a file manager puts on an
.odt, an.odsor an.odp.The drawings move from
packaging/linux/iconstopackaging/artwork, adirectory that is honest about serving all three platforms, and there are now
two per application:
<app>-document.svgand<app>-application.svg.Each consumer is pointed at whichever of the two it draws.
make-iconsrendersa second
.icoand a second.icnsper application from the document drawing;in the Store assets only
FileTypeLogocomes from it.install.ps1points aProgId's
DefaultIconat the document icon directory andApplicationIconatthe application's, and
uninstall.ps1removes both. A macOS bundle carries bothfamilies, with
CFBundleTypeIconFileandUTTypeIconFilemoved to a@DOCUMENT_ICON@placeholder. Linux installs the application drawing into thehicolor theme and still leaves a document to shared-mime-info.
Checked with clippy on the generator,
bash -non the three scripts, and asecond generator run that comes back byte identical, which is what the Windows
workflow compares against.
Left open: the submission squares under
packaging/iconscarry an alphachannel, as they did before this change, and App Store Connect refuses a 1024
icon that does. Fixing it means giving the application drawing a ground rather
than adding a flag to the generator.
🤖 Generated with Claude Code