[feedback] Add FeedbacActuatorBase, migrate FeedbackCover (cover/valve refactor 6/7)#8
Closed
exciton wants to merge 123 commits into
Closed
[feedback] Add FeedbacActuatorBase, migrate FeedbackCover (cover/valve refactor 6/7)#8exciton wants to merge 123 commits into
exciton wants to merge 123 commits into
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
…r for ESP-IDF toolchain (esphome#16599)
…ctually undoes -Werror (esphome#16604)
Signed-off-by: dependabot[bot] <support@github.com>
Mirrors the time_based and endstop refactors (PRs 2/5 and 3/5):
extracts the feedback-cover control logic into a reusable
FeedbackActuatorBase that drives any actuator entity through the
IActuator interface, and moves the cover platform into a subpackage.
New layout:
feedback/__init__.py — FeedbackActuatorBase, FEEDBACK_ACTUATOR_SCHEMA,
apply_feedback_actuator_config helpers
feedback/feedback_actuator.h — shared base class (Component + IActuator*)
feedback/feedback_actuator.cpp — shared loop / control / sensor handling
feedback/cover/__init__.py — thin cover platform, AUTO_LOAD parent
feedback/cover/feedback_cover.h — FeedbackCover : FeedbackActuatorBase, Cover
feedback/cover/feedback_cover.cpp — get_traits + dump_config
No user-visible behaviour change. Existing YAML configurations
continue to work unchanged.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Memory Impact AnalysisComponents:
📊 Component Memory Breakdown
🔍 Symbol-Level Changes (click to expand)Changed Symbols
New Symbols (top 15)
Removed Symbols (top 15)
This analysis runs automatically when components change. Memory usage is measured from a representative test configuration. |
…nit tests - Rename 6 `bin` locals to descriptive names (open_endstop, open_sensor, open_obstacle, close_endstop, close_sensor, close_obstacle) to avoid shadowing the Python built-in - Expand unit tests to match endstop/time_based suite: two test classes, 6 tests, Component-reachable-transitively check Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: dependabot[bot] <support@github.com>
…tually saves RAM (esphome#16606) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…pable SRAM (esphome#16607) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Jonathan Swoboda <154711427+swoboda1337@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the time_based and endstop refactors (PRs 2/5 and 3/5): extracts the feedback-cover control logic into a reusable FeedbackActuatorBase that drives any actuator entity through the IActuator interface, and moves the cover platform into a subpackage.
New layout:
feedback/init.py — FeedbackActuatorBase, FEEDBACK_ACTUATOR_SCHEMA,
apply_feedback_actuator_config helpers
feedback/feedback_actuator.h — shared base class (Component + IActuator*)
feedback/feedback_actuator.cpp — shared loop / control / sensor handling
feedback/cover/init.py — thin cover platform, AUTO_LOAD parent
feedback/cover/feedback_cover.h — FeedbackCover : FeedbackActuatorBase, Cover
feedback/cover/feedback_cover.cpp — get_traits + dump_config
No user-visible behaviour change. Existing YAML configurations continue to work unchanged.
What does this implement/fix?
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: