Add proper macOS app bundle packaging#390
Open
perlytiara wants to merge 2 commits into
Open
Conversation
Package native macOS .app bundles with generated .icns icons, ad-hoc signing, and a dmg2img-free extraction fallback so the build works on a standard Mac setup. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
|
Right, Github won't let me run the mac os workflow on this branch. Since this looks mostly generated by AI i'll need at least another user who can confirm this builds correctly and actually works (both intel and arm). Mac support is best effort and mostly community driven because I don't use apple devices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.appbundle for bothosx-x64andosx-arm64in the macOS build script.icnsapp icon from the existing project icon and include a properInfo.plistdmg2imgis unavailableTesting
sh Client/Platform/BuildMacos.shon macOSSysDVR Client-arm64.apphas valid signature withcodesign -vvMade with Cursor