Skip to content

bin/verify-exercises-in-docker#1629

Closed
keiravillekode wants to merge 1 commit intoexercism:mainfrom
keiravillekode:verify-exercises-in-docker
Closed

bin/verify-exercises-in-docker#1629
keiravillekode wants to merge 1 commit intoexercism:mainfrom
keiravillekode:verify-exercises-in-docker

Conversation

@keiravillekode
Copy link
Copy Markdown
Contributor

This script is useful for testing exercises against a test runner.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps
    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

Automated comment created by PR Commenter 🤖.

@angelikatyborska
Copy link
Copy Markdown
Member

Hi there! I am a bit surprised to see this PR. It doesn't have an associated issue, so it wasn't requested by the maintainers of this track. You didn't provide any explanations for why you're opening this PR. You also don't usually contribute Elixir code to this repository, so I don't think it stems from your own needs in this repository.

Could you please explain? I saw that you opened a similar PR in other tracks (exercism/racket#455).

The elixir test runner already has a script that verifies all exercises work in the test runner and it runs this script on CI.

@keiravillekode
Copy link
Copy Markdown
Contributor Author

Sorry for the trouble. We can close this PR.

To see if tracks were already testing against the test runner, I searched for docker. Now I see the track uses mix Very cool.

@keiravillekode
Copy link
Copy Markdown
Contributor Author

I was curious about which practice exercises had the slowest example solutions on various tracks. I was using verify-exercises-in-docker as an investigative tool. The PRs were not necessary.

CFML - nth-prime was exceedingly slow, remains slowest after my small PR exercism/cfml#300
Elixir - book-store is slowest
Groovy - perfect-numbers is slowest
LFE - perfect-numbers is slowest
PHP - alphametics is slowest
Racket - alphametics was slowest, leading to my solution rewrite PR exercism/racket#456
Scala - palindrome-products is slowest

I'll include these exercises in factor and risc-v tracks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants