Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
@mk-mxp Sorry I faced some sync with previous PR so created a new one. Please provide your feedback. I am happy to work on them |
|
@Narkunan To avoid that kind of trouble, you can follow these steps:
This workflow keeps your local copy as close as possible to the Exercism |
mk-mxp
left a comment
There was a problem hiding this comment.
Thank you for investing the time to sync this! Please take a look at the test data, too, before you submit the next exercise. The differences are everywhere...
| ".meta/example.php" | ||
| ] | ||
| }, | ||
| "blurb": "Given a string representing a matrix of numbers, return the rows and columns of that matrix." |
There was a problem hiding this comment.
There is more metadata in Exercism's problem specifications. Please re-run the command stated in the first line of #923 to ensure the source and source_url properties are added, too.
| { | ||
| $matrix = new Matrix("89 1903 3\n18 3 1\n9 41 800"); | ||
|
|
||
| $this->assertEquals([1903, 3, 41], $matrix->getColumn(2)); |
There was a problem hiding this comment.
This test has different data in Exercism's problem specification:
| $matrix = new Matrix("89 1903 3\n18 3 1\n9 4 800"); | |
| $this->assertEquals([1903, 3, 4], $matrix->getColumn(2)); |
| @@ -1,3 +1,3 @@ | |||
| <?php | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
This comment block should be deleted, and the one in the example.php, too.
Fix issue #923