Skip to content

fix correct regex in bob mentoring common suggestions. #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IsaacG merged 1 commit into from
May 30, 2026
Merged

fix correct regex in bob mentoring common suggestions. #2399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tracks/javascript/exercises/bob/mentoring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ solutions did not require nesting of the tests. The extra response makes it
more interesting in some languages, but in JavaScript it doesn't.

### Common suggestions
- If a student uses the complicated `RegExp` of `isShouting`, discuss its use over a simpler `message.toUpperCase() === message && /A-Z/.test(message)` which checks if there is at least one letter.
- If a student uses the complicated `RegExp` of `isShouting`, discuss its use over a simpler `message.toUpperCase() === message && /[A-Z]/.test(message)` which checks if there is at least one letter.
- If a student uses the correct `RegExp` but does _not_ use the `^` or `$` boundaries, explain how we're trying to match the entire message and not part of it. The tests won't raise a false positive, but other input might.

### Talking points
Expand Down
Loading