feat(huggingface): support local_path in download/data and bypass split verification for data_files - #29
Merged
bpiwowar merged 2 commits intoJul 31, 2026
Conversation
…it verification for data_files
Collaborator
|
A few things
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Overview
This PR improves
HuggingFaceDatasetandhf_download_and_prepareto properly handle local dataset mirrors / task output directories (local_path) and custom file patterns / single-split downloads.Key Changes
local_pathHandling inHuggingFaceDataset(src/datamaestro/data/huggingface.py):download(): Added an explicit checkif self.local_path is not None: returnto skiphf_download_and_preparewhen dataset bytes are already materialized locally on disk (e.g. from task output directories likeFlattenAndShuffleDataset).dataproperty: Whenself.local_pathis set, dataset access now loads the Arrow dataset directly from disk viadatasets.load_from_disk(str(self.local_path))(falling back toload_dataset(str(self.local_path))), preventing unnecessary Hub re-downloads andFileNotFoundErroron generated Arrow directories.Split Verification Bypass for Filtered Downloads (
src/datamaestro/download/huggingface.py):hf_download_and_prepare()to automatically passverification_mode="no_checks"wheneverdata_filesorsplitis specified.datasets.exceptions.ExpectedMoreSplitsErrorwhen downloading specific data file patterns or single splits whose recorded splits differ from total repository metadata (such as datasets where some splits likevalidationare omitted).Verification
local_pathset —prepare()completes immediately as a no-op, anddatacleanly loads the Arrow shards from disk.data_filespatterns without triggering split verification errors.