Open
Conversation
Contributor
|
Failing tests seems to be a py 3.9 issue with entmoot, or? This is also the case in your other PR. Can you have a look into this? From my point of view we could also remove 3.9 support. Were there any changes in ENTOOT? @TobyBoyne |
Collaborator
|
Hi @jduerholt, yes there was a small bug fix in entmoot, and I also pinned he gurobipy version to <12. I would hope that wouldn't introduce more bugs... From looking at the tests, I can see that many are failing due to using | to combine types instead of Union, which isn't supported in py3.9 - is this what is causing issues? |
Contributor
|
Yes, exactly this is causing the errors. @bertiqwerty: should we drop the support for 3.9? |
Contributor
|
FactorialStrategy is deprecated, FractionalFactorialStrategy can do exactly the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.