Added stat-absent checks - #102
Open
N247S wants to merge 1 commit into
Open
Conversation
dougwilson
suggested changes
Aug 30, 2021
dougwilson
left a comment
dougwilson
left a comment
Contributor
There was a problem hiding this comment.
Thanks. I added a note and also need tests and if stats can really be missing, our docs needs to note that too where we expose them
| ? file.stat.mtime.toLocaleDateString() + ' ' + file.stat.mtime.toLocaleTimeString() | ||
| : ''; | ||
| var size = file.stat && !isDir | ||
| var size = file.stat && file.stat.size && !isDir |
Contributor
There was a problem hiding this comment.
Is there a bug on Node.js regarding this? The fs.stat cannot return something other than a stat object unless it provides an error. Or is there missing logic in here regarding the error from fs.stat not getting propogated? We should probably fix the reason the stat is missing rather than the symptom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added checks for the presence of the
stat.mtimeandstat.sizeproperties in thecreateHtmlFileListfunction.For more details see this issue comment for more details.