Draft
Conversation
kbvernon
reviewed
Jul 2, 2024
Collaborator
kbvernon
left a comment
There was a problem hiding this comment.
A couple of suggestions here:
- Add an introduction that briefly explains what the reader can expect to get out of this article.
- Demonstrate the challenges of working with character strings in the R+Rust context using some examples involving Rust and extendr types -
String,Rstr,Strings,Vec<String>- and show some common errors that you think are likely to come up. - Include references to The Book: https://doc.rust-lang.org/book/ch04-01-what-is-ownership.html and https://doc.rust-lang.org/book/ch08-02-strings.html. If you think there are other sources that could be helpful, include those, too.
0387de4 to
b8e80e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow, this chapter got deleted.
I don't think it flows at all and could use some heavy suggestions.. But here it is!