Fix/code style cleanup#13
Merged
Merged
Conversation
Owner
ez-plugins
commented
Apr 19, 2026
ez-plugins
commented
- Removed Paper / MockBukkit from API to make it a Java-only package
…lution Maven resolves the full dependency graph upfront before any lifecycle phase, so -Dmaven.test.skip=true cannot prevent test-scoped dependency resolution. Building only the api module (-pl api) excludes the plugin module entirely, which is correct since JitPack consumers only depend on ezseasons-api.
The API only uses org.bukkit.event.Event and HandlerList, which have been stable since Bukkit 1.0. Pinning to 1.21.4-R0.1-SNAPSHOT decouples the API artifact from the server version so it does not need to be updated when the plugin targets a newer Minecraft/Paper release.
- api/pom.xml: remove paper-api provided dependency (API is now pure Java) - SeasonsIntegration: add default onSeasonReset(previousResetMillis, resetMillis, nextResetMillis, reason) no-op callback; existing implementations unaffected - Move SeasonResetEvent, SeasonsIntegrationRegisteredEvent, SeasonsIntegrationUnregisteredEvent from api module to plugin module (same FQN preserved; existing @eventhandler listeners recompile against plugin JAR) - SeasonManager: call onSeasonReset on all registered integrations after Bukkit event - EzSeasonsPlugin: expose getSeasonsApi() delegating to registry - docs/api.md: document onSeasonReset, note events are in plugin JAR - Bump version 2.0.3 -> 2.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.