Dev/2.1.0#14
Merged
Merged
Conversation
…lution Maven resolves the full dependency graph upfront before any lifecycle phase, so -Dmaven.test.skip=true cannot prevent test-scoped dependency resolution. Building only the api module (-pl api) excludes the plugin module entirely, which is correct since JitPack consumers only depend on ezseasons-api.
The API only uses org.bukkit.event.Event and HandlerList, which have been stable since Bukkit 1.0. Pinning to 1.21.4-R0.1-SNAPSHOT decouples the API artifact from the server version so it does not need to be updated when the plugin targets a newer Minecraft/Paper release.
- api/pom.xml: remove paper-api provided dependency (API is now pure Java) - SeasonsIntegration: add default onSeasonReset(previousResetMillis, resetMillis, nextResetMillis, reason) no-op callback; existing implementations unaffected - Move SeasonResetEvent, SeasonsIntegrationRegisteredEvent, SeasonsIntegrationUnregisteredEvent from api module to plugin module (same FQN preserved; existing @eventhandler listeners recompile against plugin JAR) - SeasonManager: call onSeasonReset on all registered integrations after Bukkit event - EzSeasonsPlugin: expose getSeasonsApi() delegating to registry - docs/api.md: document onSeasonReset, note events are in plugin JAR - Bump version 2.0.3 -> 2.1.0
Fix/code style cleanup
- README.md: version 2.0.3 → 2.1.0 throughout; update developer API section to describe the paper-free API artifact, onSeasonReset callback, and the distinction between API JAR and plugin JAR for events - docs/index.md: version 2.0.3 → 2.1.0; improve Developer API feature row - docs/getting-started.md: update download filename to 2.1.0 - docs/api.md: already updated in the refactor commit
SeasonResetCallbackUnitTest (11 tests): - singleIntegrationReceivesOnSeasonResetAfterTrigger - allRegisteredIntegrationsReceiveOnSeasonReset - unregisteredIntegrationNoLongerReceivesCallback - noRegisteredIntegrationDoesNotThrowAndEventStillFires - nullReasonNormalisedToUnspecifiedForCallback - blankReasonPassedThroughWithoutNormalisationForCallback - onSeasonResetReceivesTimestampsThatMatchTheBukkitEvent - bukkitEventFiresBeforeIntegrationCallback - nullPluginReferenceInSeasonManagerSkipsCallbackGracefully - nullApiFromPluginSkipsCallbacksWithoutNpe - defaultOnSeasonResetIsNoOp Total: 97 -> 108 tests passing. Codecov: - .codecov.yml: coverage thresholds, comment layout, test/ ignore - tests.yml: add codecov/codecov-action@v5 step after JaCoCo report in unit-test-coverage job; uploads plugin/target/site/jacoco/jacoco.xml
Codecov & Remove Paper dep from API
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ci: added jitpack workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.