Use the new sigproc binner#32
Closed
kylmcgr wants to merge 3 commits into
Closed
Conversation
cboulay
added a commit
that referenced
this pull request
Jun 26, 2026
binned.py still carried its own integer-locked event-counting binner, the last event binner not on the shared grid. Rewrite it as a thin wrapper over ezmsg.sigproc.binned_aggregate.BinnedAggregate (operation=SUM): densify sparse events to per-sample contributions, delegate all boundary/carry/axis math to the shared binner, and optionally rate-normalize. Ported from #32 (Kyle McGraw), adjusted for the enhanced sigproc shipped in 2.26.0: - fractional=False is documented and tested as int(bin_duration*fs) truncation (matching Window and BinSchedule), not round(); the sample-locked test now includes fs=30030 where truncation (600) and rounding (601) diverge. - Adds scale_by_value (weight events by stored value), a binned_event_aggregator factory, and tests for the off-nominal fractional grid, chunk invariance, count-vs-rate scaling, scale_by_value, and the sample-locked grid. This leaves Rate/EventRate on the kernel_activation path (event-optimized, O(n_events) sparse) from the companion commits; BinnedEventAggregator is now also on the shared grid, so no event binner remains on the old divergent one.
Member
|
Thanks @kylmcgr — the Two things to note about how it was brought over:
Everything green against released 2.26.0 (full suite 147 passed). I think this PR can be closed in favor of #33 — but flagging here so the attribution and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the new sigproc binner. When we merge the sigproc PR, I can take out the pyproject toml line.