Skip to content

add support for mlp and kalman to sample_adapt_regressor#13

Merged
cboulay merged 3 commits into
devfrom
sample-adapt-regressor-mlp-kalman
Jun 26, 2026
Merged

add support for mlp and kalman to sample_adapt_regressor#13
cboulay merged 3 commits into
devfrom
sample-adapt-regressor-mlp-kalman

Conversation

@kylmcgr

@kylmcgr kylmcgr commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Sample adaptive regressor works in the cursor pipeline with Kalman and MLP (torch) models.

@kylmcgr kylmcgr requested a review from cboulay June 24, 2026 16:38
@kylmcgr kylmcgr self-assigned this Jun 24, 2026
@cboulay

cboulay commented Jun 26, 2026

Copy link
Copy Markdown
Member
  1. I don't really like having multiple inert units and then only wiring up one of them. This can lead to mistakes. e.g., you rewired the signal but you did not rewire the sampler: (self.SEQSEQSAMPLER.OUTPUT_SAMPLE, self.REGRESSOR.INPUT_SAMPLE) has no equivalent for the other backends.
    I have another pattern that you can use that I will send you.

  2. I'm not sure about the shape and axes. If we use a non-zero decode_window_dur then the windower's output has a leading "win" axis. Then we flatten, and honestly I can't remember what that does but it looks like preserve_axis="win" would keep the win axis? So when we get to DecodeOputputAdapterProcessor, it only brings the time axis through if there is a "time" axis. Do we have that?

kylmcgr and others added 2 commits June 26, 2026 10:49
Chains the real Window -> Flatten -> DecodeOutputAdapter processors to
lock the win->time axis rename that makes the adapter's time-axis guard
safe on the windowed mlp/kalman path. A future change to Flatten's
sample_axis semantics now fails here instead of only at runtime.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@cboulay cboulay merged commit fc0e080 into dev Jun 26, 2026
8 checks passed
@cboulay cboulay deleted the sample-adapt-regressor-mlp-kalman branch June 26, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants