Add sync_blocking outlet setting for transp_sync_blocking transport#35
Merged
Conversation
Depend on pylsl>=1.18.3b1 to expose the new StreamOutlet transport_flags parameter. Add LSLOutletSettings.sync_blocking (default False) which, when True, creates the outlet with pylsl.transp_sync_blocking to enable the synchronous zero-copy transport for high-bandwidth streams. Add unit tests and document the setting in the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the new synchronous (zero-copy) outlet transport from pylsl#115 as an opt-in
LSLOutletSettingsoption.pylsldependency to>=1.18.3b1(the beta that exposes theStreamOutlet(..., transport_flags=...)parameter andtransp_*constants).LSLOutletSettings.sync_blocking(defaultFalse). WhenTrue, the outlet is created withpylsl.transp_sync_blocking, enabling the synchronous zero-copy transport for high-bandwidth streams. Default behavior is unchanged (transp_default).sync_blocking) in the README.Tests
Added two network-free unit tests that patch
pylsl.StreamOutletto assert thetransport_flagspassed for each setting:test_outlet_default_transport_flags→transp_defaulttest_outlet_sync_blocking_transport_flags→transp_sync_blocking```
$ uv run pytest tests/test_outlet.py -q
3 passed
```