Don't crash in butter_design_fun when order > 0 with no corners#156
Merged
Conversation
order > 0 with neither cuton nor cutoff set is a valid "no filter" request: filter_specs() returns None, which butter_design_fun now treats as passthrough (coefs stays None -> the transformer returns the input unchanged) instead of crashing on an unpack of None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
order > 0 with neither cuton nor cutoff set is a valid "no filter" request: filter_specs() returns None, which butter_design_fun now treats as passthrough (coefs stays None -> the transformer returns the input unchanged) instead of crashing on an unpack of None.