Extract BinSchedule: shared bin-boundary primitive#158
Merged
Conversation
Hoist the bin-boundary arithmetic out of BinnedAggregateTransformer into a
reusable, backend-agnostic BinSchedule (ezmsg.sigproc.util.binning) so that
every consumer that needs fixed-duration binning lands on the same grid by
sharing one schedule rather than re-deriving the formula.
- BinSchedule owns fs, samples-per-bin, output gain/offset, the global bin
index, and the carried sample count; it touches no array data. Consumers
layer their own data carry (raw samples here; a scalar partial-sum for an
event counter) on top of the shared boundaries.
- BinnedAggregateTransformer now delegates all boundary/gain/offset math to
BinSchedule.advance() and only slices+aggregates at the returned cut points.
- Integer mode now truncates (int) instead of round() so the sample-locked
grid matches Window's int(window_dur*fs) for any rate, not just when the
fractional part is < 0.5.
- test_bin_schedule.py pins fractional=True against a faithful port of
EventRate's accumulator algorithm and fractional=False against Window's
grid, across chunkings and at fs in {30000, 30012, 30030}. The 30030 case
(spb=600.6) is where truncation vs rounding diverges.
This converts the previous "agreement with EventRate by construction, untested"
into shared code with a regression test, and sets up EventRate (ezmsg-event) to
delegate to the same primitive.
test_concat_along_ch drove its coroutine via asyncio.get_event_loop() .run_until_complete(), which raises "no current event loop" on Python 3.10+ once any earlier test in the suite has called asyncio.run() (which clears the loop policy). It passed in isolation but failed after, e.g., test_binned_aggregate's asyncio.run()-based test. Use asyncio.run(), which is self-contained and order-independent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoist the bin-boundary arithmetic out of BinnedAggregateTransformer into a reusable, backend-agnostic BinSchedule (ezmsg.sigproc.util.binning) so that every consumer that needs fixed-duration binning lands on the same grid by sharing one schedule rather than re-deriving the formula.
This converts the previous "agreement with EventRate by construction, untested" into shared code with a regression test, and sets up EventRate (ezmsg-event) to delegate to the same primitive.