Conversation
|
Hi and thanks @xrow Can you please create an issue on Jira and describe what you're contributing? |
|
ping @paulborgermans |
|
-1: |
|
2,5 is a valid php float. Conversion needs to happen exactly there. PHP isn't like other languages unfortunatelly. |
|
|
I see your point with the locale. Unfortuatelly this means somewhere in the installation setlocale isn`t properly used. I investigate on that one. Can you point out what is wrong with the schema? |
|
On having more robustness towards any other locale, see this gist: https://gist.github.com/paulborgermans/0d10f4d99f3fb0a7a3c8 location in schema on the other hand: 4 underscores instead of 3 in the new dynamic fields added, and also the fieldtype for location is missing hth |
|
@xrow Issue closed as you requested, can you close this pull request ? |
|
The pull request yet has this feature, but I can live without it since we patch the sources anyway. Up to you. |
|
Hi, implementing a different naming for the dynamic field is too much work on our end. Lets forget the feature request and lets close the pull. In addition I would very much prefer the patch (https://gist.github.com/paulborgermans/0d10f4d99f3fb0a7a3c8 ) that @paulborgermans is proposing, but I would need it in 5.4 branch. |
|
ping @andrerom regarding @paulborgermans patch |
|
|
so should we close this PR ? |
No description provided.