Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,12 @@ jobs:
if: ${{ needs.needs-build.outputs.needs-wasm == 'true' }}
runs-on: ubuntu-latest
container:
image: ghcr.io/faasm/examples-build:0.6.0_0.4.0
image: ghcr.io/faasm/examples-build:0.8.0_0.4.0
steps:
- name: "Checkout code"
uses: actions/checkout@v4
with:
submodules: true
- name: "Build Rabe and JWT"
run: |
export PATH=$PATH:/root/.cargo/env
rustup default stable
rustup target add wasm32-wasip1
./bin/inv_wrapper.sh rabe jwt
- name: "Build OpenCV"
run: ./bin/inv_wrapper.sh opencv
- name: "Build FFmpeg"
Expand Down Expand Up @@ -138,7 +132,7 @@ jobs:
shell: bash
env:
FAASM_INI_FILE: ./faasm.ini
FAASM_VERSION: 0.29.0
FAASM_VERSION: 0.33.0
FAASM_WASM_VM: ${{ matrix.faasm_wasm_vm }}
steps:
- uses: csegarragonz/set-compose-version-action@main
Expand Down Expand Up @@ -312,14 +306,6 @@ jobs:
- name: "Run FFmpeg check"
timeout-minutes: 1
run: faasmctl invoke ffmpeg check
- name: "Run Rabe test"
if: "contains(env.FAASM_WASM_VM, 'wamr')"
timeout-minutes: 1
run: faasmctl invoke rabe test
# - name: "Run JWT test"
# if: "contains(env.FAASM_WASM_VM, 'wamr')"
# timeout-minutes: 1
# run: faasmctl invoke jwt test
- name: "Print upload logs in case of failure"
if: failure()
run: faasmctl logs -s upload
Expand Down
2 changes: 1 addition & 1 deletion docker/base.dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ubuntu:22.04 AS base
FROM ubuntu:24.04 AS base

RUN apt update \
&& apt install -y \
Expand Down
26 changes: 12 additions & 14 deletions docker/build.dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ARG CPP_VERSION
ARG EXAMPLES_VERSION
# Base image is not re-built often and tag may lag behind
FROM ghcr.io/faasm/examples-base:0.6.0_0.4.0 AS base
FROM ghcr.io/faasm/examples-base:0.8.0_0.4.0 AS base
FROM ghcr.io/faasm/cpp-sysroot:${CPP_VERSION:-dead}

SHELL ["/bin/bash", "-c"]
Expand All @@ -10,23 +10,27 @@ ENV IN_DOCKER="on"
# Copy built OpenMPI from previous step
COPY --from=base /tmp/openmpi-4.1.0/ /tmp/openmpi-4.1.0/

# Install OpenMP
ARG DEBIAN_FRONTEND=noninteractive
RUN apt update \
&& apt install -y --no-install-recommends \
build-essential \
curl \
libomp-17-dev \
unzip \
&& rm -rf /var/lib/apt/lists/*

# Install OpenMPI
RUN cd /tmp/openmpi-4.1.0 \
&& make install \
&& cd /tmp \
&& rm -rf /tmp/openmpi-4.1.0 /tmp/openmpi-4.1.0.tar.bz2

# Install OpenMP
ARG DEBIAN_FRONTEND=noninteractive
RUN apt update \
&& apt install -y libomp-17-dev

# Install rust
RUN curl --proto '=https' --tlsv1.3 https://sh.rustup.rs -sSf | sh -s -- -y \
&& source ~/.cargo/env \
&& rustup target add wasm32-wasip1


# Fetch the code and update submodules
ARG EXAMPLES_VERSION
RUN mkdir -p code \
Expand All @@ -46,9 +50,7 @@ RUN mkdir -p code \
&& git submodule update --init -f examples/LULESH \
&& git submodule update --init -f examples/libpng \
&& git submodule update --init -f examples/polybench \
&& git submodule update --init -f examples/rabe \
&& git submodule update --init -f examples/tensorflow \
&& git submodule update --init -f examples/tless-jwt
&& git submodule update --init -f examples/tensorflow

# Build the examples and demo functions
ENV PATH=${PATH}:/root/.cargo/bin
Expand All @@ -64,7 +66,6 @@ RUN cd /code/examples \
&& inv polybench --native \
# Build the WASM applications
&& inv ffmpeg \
&& inv jwt \
# ImageMagick needs libpng
&& inv libpng imagemagick \
&& inv kernels \
Expand All @@ -73,14 +74,11 @@ RUN cd /code/examples \
&& inv lammps --migration-net \
&& inv lulesh \
&& inv polybench \
&& inv rabe \
&& inv tensorflow \
# These demo functions link with the cross-compiled static libraries
&& inv func ffmpeg check \
&& inv func jwt test \
&& inv func lammps chain \
&& inv func mpi migrate \
&& inv func rabe test \
&& inv func tf check

# Prepare bashrc
Expand Down
2 changes: 1 addition & 1 deletion examples/tensorflow
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
black>=22.3.0
faasmctl>=0.32.0
faasmctl>=0.51.0
flake8>=4.0.1
invoke>=1.7.1
python-lsp-server[all]>=1.12.0
Expand Down
3 changes: 0 additions & 3 deletions tasks/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ def build(ctx, ctr, nocache=False, push=False):
build_args=build_args,
)

if push:
push(ctx, [c])


@task(iterable=["ctr"])
def push(ctx, ctr):
Expand Down
6 changes: 3 additions & 3 deletions tasks/env.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from faasmtools.build import FAASM_LOCAL_DIR
from faasmtools.docker import ACR_NAME
from faasmtools.docker import CR_NAME
from faasmtools.env import get_version as get_cpp_version
from os import environ
from os.path import dirname, abspath, join
Expand All @@ -14,9 +14,9 @@

# Docker variables
EXAMPLES_BUILD_IMAGE_CTR = "examples-build-workon"
EXAMPLES_BUILD_IMAGE_NAME = "{}/examples-build".format(ACR_NAME)
EXAMPLES_BUILD_IMAGE_NAME = "{}/examples-build".format(CR_NAME)
EXAMPLES_BUILD_DOCKERFILE = join(DOCKER_ROOT, "build.dockerfile")
EXAMPLES_BASE_IMAGE_NAME = "{}/examples-base".format(ACR_NAME)
EXAMPLES_BASE_IMAGE_NAME = "{}/examples-base".format(CR_NAME)
EXAMPLES_BASE_DOCKERFILE = join(DOCKER_ROOT, "base.dockerfile")

# Shared files data
Expand Down
1 change: 0 additions & 1 deletion tasks/func.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def tests(ctx, clean=False):
["ffmpeg", "check"],
["opencv", "check"],
["opencv", "pca"],
["rabe", "test"],
["tf", "check"],
# TODO: this two functions are not used in the tests, as they are used
# to exercise migration, for what we need a distributed test setting
Expand Down
Loading