Skip to content

API documentation - #4

Merged
iosonofabio merged 34 commits into
fabilab:mainfrom
haircutt:docs/api
May 8, 2026
Merged

API documentation#4
iosonofabio merged 34 commits into
fabilab:mainfrom
haircutt:docs/api

Conversation

@haircutt

Copy link
Copy Markdown
Contributor

Created api.md, and explored the use of Sphinx autodoc and autofunc to start creating api documentation.

@haircutt

haircutt commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

Pipeline errors w/ regards to the API look to be correctly running now - the two failing pipelines appear to be from other tests

@haircutt
haircutt marked this pull request as ready for review April 7, 2026 07:12
@iosonofabio

Copy link
Copy Markdown
Contributor

Fixed the bug on CI from my end and merged main into this PR, let's see if it passes CI and we can take it from there

@iosonofabio

Copy link
Copy Markdown
Contributor

I have added some improvements to the structure, docstrings, and toctree. I've also added a section on data providers which is really important because this aims to be a universal input library that layouts any network.

Could you please take a look, pull into your local branch, and then try to improve further from here?

Thanks!

@iosonofabio

Copy link
Copy Markdown
Contributor

Thanks @haircutt

why is there featureTable.md but also feature_table.md? Please fix and also decide how people are going to find the table from the doc homepage.

fix: deleted redundant file, correct file should be feature_table.md.
@haircutt

Copy link
Copy Markdown
Contributor Author

why is there featureTable.md but also feature_table.md? Please fix and also decide how people are going to find the table from the doc homepage.

featureTable should have been renamed to feature_table.md, resolved now

@iosonofabio

iosonofabio commented Apr 23, 2026 via email

Copy link
Copy Markdown
Contributor

@haircutt

haircutt commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

... and the other issue?

Should have added this correctly now

@iosonofabio

Copy link
Copy Markdown
Contributor

the second issue is still the same: how are people expected to find the table when they browse the documentation home page?

Maybe you could add a short sentence and a link on the main API page?

@haircutt

Copy link
Copy Markdown
Contributor Author

the second issue is still the same: how are people expected to find the table when they browse the documentation home page?

Maybe you could add a short sentence and a link on the main API page?

I see, I tried to add the page to the nav tab originally, but have also incorporated a link into the API page now

@iosonofabio

Copy link
Copy Markdown
Contributor

Just pinging that a few items from the code review look like they are still pending, can you please check out the review above and reply to the individual requests? Thanks

@haircutt haircutt left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finalised for review - API documentation and feature table

@iosonofabio

Copy link
Copy Markdown
Contributor

ahem, @haircutt the review issues above and in the "Files changes" tab seem all still there, therefore it is not finalised. Can you please take a look? Or we can meet up and go through them in person

@iosonofabio

Copy link
Copy Markdown
Contributor

Also as a quick heads-up, I have pushed a few commits to main to add some centering and rotating options. It would be great if you could, in addition to take a look at the reviews (see previous comment), also:

  • pull main into this branch with the latest commits
  • update the feature table based on the new parameters (just a few new supported options, should not take too long)

Thank you!

@haircutt

haircutt commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

ahem, @haircutt the review issues above and in the "Files changes" tab seem all still there, therefore it is not finalised. Can you please take a look? Or we can meet up and go through them in person

Can I come in Friday to clarify what I was supposed to do? 😅may have misinterpreted

@iosonofabio

iosonofabio commented May 6, 2026 via email

Copy link
Copy Markdown
Contributor

Comment thread docs/source/feature_table.md Outdated
Comment thread docs/source/feature_table.md Outdated
Comment thread docs/source/feature_table.md Outdated
Comment thread python/ilayoutx/__init__.py
Comment thread python/ilayoutx/routing/__init__.py
Comment thread python/ilayoutx/packing/__init__.py
Comment thread docs/source/conf.py Outdated
Comment thread docs/source/conf.py
# Source code links (credit to the matplotlib project for this part)
# -----------------------------------------------------------------------------

import sys

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check you really need these imports?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs appear to fail in build without these, there is use of os, path and sys calls in the try blocks below, unless the link_github should be set to false?

@iosonofabio
iosonofabio merged commit 1fe2a16 into fabilab:main May 8, 2026
8 checks passed
@iosonofabio

Copy link
Copy Markdown
Contributor

Thank you!! Great job!

@haircutt
haircutt deleted the docs/api branch May 8, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants