feat: add type checking for ncores and memory setters#261
Merged
Conversation
nakul680
changed the title
ncores and memory settersncores and memory setters
haneug
requested changes
Jul 10, 2026
Contributor
There was a problem hiding this comment.
Thanks for the PR. Please correct the issue number in the Change log section and add it to the actual CHANGELOG.md file
Edit: Also the Change log section should only be one thing in Added. Something like Added: type checks for ncore and memory. That the feature comes with tests does not need to be mentioned in the Change-log.
haneug
added
enhancement
haneug
requested changes
Jul 13, 2026
haneug
left a comment
haneug
left a comment
Contributor
There was a problem hiding this comment.
Please add the release notes to the CHANGELOG.md file. It seems that your release note is incomplete. Also remove the dots ... below Closes, the (Project adheres to Keep a Changelog; Every entry should start in upper-case and end with (#<pr-id>); Remove sections that don't apply), and the empty point in the description of your PR.
haneug
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issues
Closes #259
Description
ncoresandmemoryproperties inInput. Additionally it will be checked if the value given is positive.Release Notes
Added
ncoresandmemorysetters in and checks for invalid negative values.(feat: add type checking forncoresandmemorysetters #261)