Fix manifold mkdir error with run_remote benchmark submission#497
Fix manifold mkdir error with run_remote benchmark submission#497MarkAndersonIX wants to merge 1 commit into
Conversation
Summary: Adds lock context managers around uploads to avoid case where manifold client sync_mkdir might get called more than once, causing file not to be uploaded. Reviewed By: axitkhurana Differential Revision: D36020165 fbshipit-source-id: 7705baf2ce52f98a09456e10189de8e0e70b6d3d
|
This pull request was exported from Phabricator. Differential Revision: D36020165 |
|
Hi @MarkAndersonIX! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
2 participants
Summary: Adds lock context managers around uploads to avoid case where manifold client sync_mkdir might get called more than once, causing file not to be uploaded.
Reviewed By: axitkhurana
Differential Revision: D36020165