Fix operation error flash showing function source code instead of translated message#1775
Draft
Fix operation error flash showing function source code instead of translated message#1775
Conversation
Co-authored-by: jenningsanderson <1637425+jenningsanderson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix merge error message displaying source code
Fix operation error flash showing function source code instead of translated message
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a disabled operation is triggered (e.g. merging incompatible features), the flash notification at the bottom of the map displayed raw JS source code instead of the localized error string.
Root cause:
operation.tooltip(function reference) was passed to.label()instead ofoperation.tooltip()(its return value).flash.label()stores the value as_labeland renders it via.html(utilSanitizeHTML(_label))— when_labelis a function, JS coerces it to its source via.toString().Affected files:
modules/behaviors/KeyOperationBehavior.js— keyboard-triggered operationsmodules/modes/SelectOsmMode.js— click-triggered operations in OSM select modemodules/ui/edit_menu.js— touch/pen interactions via the edit menuOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.