fix(core): align loading spinner inside TextArea corner (#4232)#4244
Open
Geervan wants to merge 2 commits into
Open
fix(core): align loading spinner inside TextArea corner (#4232)#4244Geervan wants to merge 2 commits into
Geervan wants to merge 2 commits into
Conversation
Geervan
requested review from
cixzhang,
ejhammond and
imdreamrunner
as code owners
July 23, 2026 05:28
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
requested review from
cvkxx,
ernestt,
kentonquatman and
rubyycheung
July 23, 2026 05:29
Contributor
PR Analysis ReportModified ComponentsField
TextArea
Bundle Size Summary
Accessibility AuditStatus: 1 accessibility violation(s) found — 1 serious. TextArea - 1 issue(s)
Generated by PR Enrichment workflow | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4232.
In
TextArea'sisLoading(busy) state, the loadingSpinnerwas previously rendered without positioning container styles, causing it to fall into normal flow outside the field wrapper or overlap scrollbars.This PR updates
TextAreato anchor the loading spinner inside the top-right corner of the field wrapper using flex alignment, matching the status icon layout without interfering with native vertical scrollbars.Changes Made
packages/core/src/TextArea/TextArea.tsx:Spinnerin aspinnerIcon<span>styled as a flex item (alignSelf: 'flex-start',marginInlineStart: spacingVars['--spacing-2']).status && !isBusy) so the busy spinner takes precedence without overlapping validation icons.<textarea>in flex flow (flex: 1) so native scrollbars remain contained inside<textarea>and do not overlap the spinner.apps/storybook/stories/TextArea.stories.tsx:isLoadingcontrols and theIsLoadingstory for visual testing.packages/core/src/TextArea/TextArea.test.tsx:isLoadingrenders the positioned spinner container and suppresses status icons.Test Plan
npx vitest run packages/core/src/TextArea/TextArea.test.tsx(59/59 passed).<TextArea isLoading />in Storybook (http://localhost:6006/?path=/story/textarea--is-loading).