fix(CommandPalette): forward BaseProps pass-through attributes to Dialog#4288
Open
cixzhang wants to merge 1 commit into
Open
fix(CommandPalette): forward BaseProps pass-through attributes to Dialog#4288cixzhang wants to merge 1 commit into
cixzhang wants to merge 1 commit into
Conversation
CommandPalette extends BaseProps but previously had no ...rest capture, silently dropping consumer pass-through attributes (className, style, xstyle, data-testid, aria-describedby, etc.). Capture and forward them to the underlying Dialog element.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR Modified ComponentsCommandPalette · View in Storybook
Bundle Size Summary
Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CommandPalette extends
BaseProps<HTMLDialogElement>but had no...restcapture in its destructure. Consumer pass-through attributes (className, style, xstyle, data-testid, aria-describedby, id, etc.) were silently dropped.This adds a rest capture and forwards it to the underlying Dialog, so BaseProps attributes reach the DOM as expected.
Needs Review
ContextMenu and DropdownMenu share the same pattern (discriminated union props with no rest forwarding). Those are more complex to fix cleanly because of the union type and the two-element render split. Filed as a note for a future pass.
Night Watch — Component Auditor