airstore next: bundle V4: thrift working in OSS build#48
Open
codyohl wants to merge 1 commit intofacebook:mainfrom
Open
airstore next: bundle V4: thrift working in OSS build#48codyohl wants to merge 1 commit intofacebook:mainfrom
codyohl wants to merge 1 commit intofacebook:mainfrom
Conversation
codyohl
force-pushed
the
export-D56578071
branch
from
cbff7fc to
9ce6c6e
Compare
Summary: this diff adds support for thrift in the OSS client build. it changes the `getdeps` airstore manifest to gain access to the thrift cpp2 compiler, then uses a rule similar to other projects to generate the cpp type headers. It changes the OSS `libbundle` library to depend on the thrift types introduced in D56578073 (and, through a lot of pain, get generated in the OSS build stack) which will then be used to ser/de bundles in the OSS build later in the stack! Differential Revision: D56578071
codyohl
force-pushed
the
export-D56578071
branch
from
9ce6c6e to
c17b1ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: this diff adds support for thrift in the OSS client build. it changes the
getdepsairstore manifest to gain access to the thrift cpp2 compiler, then uses a rule similar to other projects to generate the cpp type headers. It changes the OSSlibbundlelibrary to depend on the thrift types introduced in D56578073 (and, through a lot of pain, get generated in the OSS build stack) which will then be used to ser/de bundles in the OSS build later in the stack!Differential Revision: D56578071