igl | vulkan | Don't clear MemoryLess color attachment. #339
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corporateshark
approved these changes
Jan 15, 2026
|
@corporateshark has imported this pull request. If you are a Meta employee, you can view this in D90784867. |
| if (aspect == VK_IMAGE_ASPECT_COLOR_BIT && samples == VK_SAMPLE_COUNT_1_BIT && | ||
| (usageFlags & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) != 0) { | ||
| (usageFlags & VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT) != 0 && | ||
| (usageFlags & VK_IMAGE_USAGE_TRANSFER_DST_BIT) != 0) { |
Contributor
There was a problem hiding this comment.
Why not VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT?
Contributor
Author
There was a problem hiding this comment.
Because it assert failed at line 1051 in VulkanImage::clearColorImage if i create a memory less color attachment, so i use VK_IMAGE_USAGE_TRANSFER_DST_BIT directly.
igl/src/igl/vulkan/VulkanImage.cpp
Line 1051 in c74aefa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.