-
Notifications
You must be signed in to change notification settings - Fork 25k
Move AnimationBackend initialization from Animated #55103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89663251. |
Job Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: run_fantom_tests
|
Summary: This diff decouples AnimationBackend from Animated. Now the backend is intialized in the Scheduler, from where it's passed to UIManager. Animation frontends (such as Animated) can then obtain a reference to the backend, and use it to schedule animation frame updates. # Changelog [General] [Changed] - Moved AnimationBackend initiailzation to `Scheduler` [General] [Added] - `AnimationChoreographer` interface with an implementation for fantom tests Differential Revision: D89663251
d30a62f to
8518901
Compare
Job Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: run_fantom_tests
|
Summary: This diff decouples AnimationBackend from Animated. Now the backend is intialized in the Scheduler, from where it's passed to UIManager. Animation frontends (such as Animated) can then obtain a reference to the backend, and use it to schedule animation frame updates. # Changelog [General] [Changed] - Moved AnimationBackend initiailzation to `Scheduler` [General] [Added] - `AnimationChoreographer` interface with an implementation for fantom tests Differential Revision: D89663251
8518901 to
a6e523e
Compare
Job Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: run_fantom_tests
|
Summary: Pull Request resolved: #55103 This diff decouples AnimationBackend from Animated. Now the backend is intialized in the Scheduler, from where it's passed to UIManager. Animation frontends (such as Animated) can then obtain a reference to the backend, and use it to schedule animation frame updates. # Changelog [General] [Changed] - Moved AnimationBackend initiailzation to `Scheduler` [General] [Added] - `AnimationChoreographer` interface with an implementation for fantom tests Differential Revision: D89663251
a6e523e to
2663e37
Compare
Job Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: run_fantom_tests
|
Summary: Pull Request resolved: #55103 This diff decouples AnimationBackend from Animated. Now the backend is intialized in the Scheduler, from where it's passed to UIManager. Animation frontends (such as Animated) can then obtain a reference to the backend, and use it to schedule animation frame updates. # Changelog [General] [Changed] - Moved AnimationBackend initiailzation to `Scheduler` [General] [Added] - `AnimationChoreographer` interface with an implementation for fantom tests Differential Revision: D89663251
2663e37 to
02c9496
Compare
Job Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: run_fantom_tests
|
02c9496 to
b090c23
Compare
Summary: Pull Request resolved: #55103 This diff decouples AnimationBackend from Animated. Now the backend is intialized in the Scheduler, from where it's passed to UIManager. Animation frontends (such as Animated) can then obtain a reference to the backend, and use it to schedule animation frame updates. # Changelog [General] [Changed] - Moved AnimationBackend initiailzation to `Scheduler` [General] [Added] - `AnimationChoreographer` interface with an implementation for fantom tests Differential Revision: D89663251
|
This pull request was successfully merged by Bartlomiej Bloniarz in b090c23 When will my fix make it into a release? | How to file a pick request? |
Job Summary for GradleTest All :: run_fantom_tests
|
Differential Revision: D89663244
b090c23 to
a57d48a
Compare
Summary: Pull Request resolved: #55103 This diff decouples AnimationBackend from Animated. Now the backend is intialized in the Scheduler, from where it's passed to UIManager. Animation frontends (such as Animated) can then obtain a reference to the backend, and use it to schedule animation frame updates. # Changelog [General] [Changed] - Moved AnimationBackend initiailzation to `Scheduler` [General] [Added] - `AnimationChoreographer` interface with an implementation for fantom tests Differential Revision: D89663251
Job Summary for GradleTest All :: build_android
|
Job Summary for GradleTest All :: run_fantom_tests
|
Summary: Pull Request resolved: #55103 This diff decouples AnimationBackend from Animated. Now the backend is intialized in the Scheduler, from where it's passed to UIManager. Animation frontends (such as Animated) can then obtain a reference to the backend, and use it to schedule animation frame updates. # Changelog [General] [Changed] - Moved AnimationBackend initiailzation to `Scheduler` [General] [Added] - `AnimationChoreographer` interface with an implementation for fantom tests Differential Revision: D89663251
a57d48a to
ede988f
Compare
|
This pull request was successfully merged by Bartlomiej Bloniarz in ede988f When will my fix make it into a release? | How to file a pick request? |
Job Summary for GradleTest All :: run_fantom_tests
|
Summary:
This diff decouples AnimationBackend from Animated. Now the backend is intialized in the Scheduler, from where it's passed to UIManager. Animation frontends (such as Animated) can then obtain a reference to the backend, and use it to schedule animation frame updates.
Changelog
[General] [Changed] - Moved AnimationBackend initiailzation to
Scheduler[General] [Added] -
AnimationChoreographerinterface with an implementation for fantom testsDifferential Revision: D89663251