Skip to content

Typegen sorting and wrapping #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaartenStaa wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Typegen sorting and wrapping #3818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5185095
Combination of four diffs
rbalicki2 Feb 25, 2022
e4e4c92
Sort enum members.
Feb 26, 2022
c671d16
Sort fragment refs.
Feb 26, 2022
6f4e49f
Only wrap unions & intersections if needed.
Feb 26, 2022
dbbfc3f
Impl Ord for AST in typegen, sort all unions and intersections.
Mar 2, 2022
ea9ee4e
Merge remote-tracking branch 'upstream/main' into typegen-sorting-and…
Mar 2, 2022
b3f8072
Remove AST::Intersection from typegen, as it will not be needed.
Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
18 changes: 18 additions & 0 deletions compiler/crates/relay-config/src/typegen_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ pub struct TypegenConfig {
/// This option enables emitting es modules artifacts.
#[serde(default)]
pub eager_es_modules: bool,

/// This option controls which emitted files have sorted fields, fragment names,
/// and union members. It also controls whether unions with more than one element
/// are written with surrounding parentheses.
#[serde(default)]
pub sort_typegen_items: SortTypegenItemsConfig,
}

#[derive(Debug, Serialize, Deserialize, Clone, Copy)]
Expand Down Expand Up @@ -139,3 +145,15 @@ impl FlowTypegenPhase {
}
}
}

#[derive(Debug, Serialize, Deserialize, Clone, Copy, Default)]
pub struct SortTypegenItemsConfig {
#[serde(default)]
pub rollout: Rollout,
}

impl SortTypegenItemsConfig {
pub fn should_sort(&self, rollout_key: StringKey) -> bool {
self.rollout.check(rollout_key.lookup())
}
}
Loading