Vendor debug-adapter-protocol types - #213
Open
Expyron wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
|
This pull request has been imported. If you are a Meta employee, you can view this in D110561098. (Because this pull request was imported automatically, there will not be any future comments.) |
Contributor
|
That's a shame. It would be really nice if there was an upstream crate that did this for us, since I'd rather starlark didn't maintain it's own debug bindings. I assume something else in Rust world has a DAP binding? |
Author
|
There are a few crates that expose DAP bindings, but all of them appear unmaintained: Vendoring seemed to be the simpler solution, especially as the bindings are auto-generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
debugserver-typesdependency has not been maintained in 7 years.This PR vendors the latest version of the official JSON Schema DAP specification and uses
typifyto convert it to Rust types.All code changes are to conform to updated specification (mostly new fields), and to the slightly different conversion performed by typify.