This repository was archived by the owner on Aug 8, 2025. It is now read-only.
fixed the complex typing.List[str] problem in imr.py fixes #129#165
Open
Eshan-Jogwar wants to merge 1 commit into
Open
fixed the complex typing.List[str] problem in imr.py fixes #129#165Eshan-Jogwar wants to merge 1 commit into
Eshan-Jogwar wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the imr.py at the place of error expected a Leaf class which has a value of type string. The fix uses unicode() function on the Node class to generate a string from all the Leaf classes which are part of the Node instance there to generate the string required at the place.
as i could figure out the function unicode() joins the value from all the Leaf Nodes part of the Node instance.
the code is handled as a run time exception by try and except in imr.py line 52.
fixes #129