Fix floating-point comparison bug in _get_tpr_index#109
Closed
du1204 wants to merge 1 commit into
Closed
Conversation
Summary: Fix `IndexError` in `_get_tpr_index` caused by exact float equality (`==`) against `np.linspace`-generated thresholds (e.g., `0.060000000000000005 ≠ 0.06`). Found via F1040508640. Replaced with `AnalysisNode.get_tpr_index()` static method using `np.isclose`, which raises `ValueError` on true misalignment. All call sites updated to use the shared method directly. Reviewed By: mgrange1998 Differential Revision: D94187721
meta-cla
Bot
added
the
CLA Signed
|
This pull request has been merged in 4d15e39. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix
IndexErrorin_get_tpr_indexcaused by exact float equality (==) againstnp.linspace-generated thresholds (e.g.,0.060000000000000005 ≠ 0.06). Found via F1040508640.Replaced with
AnalysisNode.get_tpr_index()static method usingnp.isclose, which raisesValueErroron true misalignment. All call sites updated to use the shared method directly.Reviewed By: mgrange1998
Differential Revision: D94187721