Editing README of external PrivacyGuard github repo#119
Closed
matthieumeeus wants to merge 1 commit into
Closed
Conversation
Summary: In diff [D96365690](https://www.internalfb.com/diff/D96365690?dst_version_fbid=824565110674273), we introduced codeBLEU as a similarity metric to compare different pieces of code. For this, we added codebleu==0.6.0 as a dependency, which requires tree-sitter==0.20.4 when codebleu is being built. While we had updated the `github/pyproject.toml` and the `github/reusable_test.yml` to account for this in the external PrivacyGuard repo, we did not update the corresponding installation instructions in the external README.md to accommodate this. I tried the current installation instructions and it failed because of the codebleu/tree-sitter dependency. This diff corrects the instructions. Differential Revision: D98360821
meta-cla
Bot
added
the
CLA Signed
|
@matthieumeeus has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98360821. |
|
This pull request has been merged in d6202ce. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In diff D96365690, we introduced codeBLEU as a similarity metric to compare different pieces of code.
For this, we added codebleu==0.6.0 as a dependency, which requires tree-sitter==0.20.4 when codebleu is being built.
While we had updated the
github/pyproject.tomland thegithub/reusable_test.ymlto account for this in the external PrivacyGuard repo, we did not update the corresponding installation instructions in the external README.md to accommodate this.I tried the current installation instructions and it failed because of the codebleu/tree-sitter dependency.
This diff corrects the instructions.
Differential Revision: D98360821