Skip to content
This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]
### Added
- Secrets Manager Service
- TLS cert installer script
### Changed
### Removed

Expand Down
19 changes: 19 additions & 0 deletions fbpcp/entity/secret.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#!/usr/bin/env python3
# Copyright (c) Meta Platforms, Inc. and affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

# pyre-strict

from dataclasses import dataclass, field
from typing import Dict


@dataclass
class StringSecret:
id: str
name: str
value: str
create_date: str
tags: Dict[str, str] = field(default_factory=dict)
96 changes: 96 additions & 0 deletions fbpcp/gateway/secrets_manager.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
#!/usr/bin/env python3
# Copyright (c) Meta Platforms, Inc. and affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

# pyre-strict

from functools import reduce
from typing import Any, Dict, List, Optional

import boto3
from botocore.client import BaseClient
from fbpcp.decorator.error_handler import error_handler
from fbpcp.entity.secret import StringSecret
from fbpcp.gateway.aws import AWSGateway
from fbpcp.util.aws import convert_list_to_dict


class AWSSecretsManagerGateway(AWSGateway):
def __init__(
self,
region: str,
access_key_id: Optional[str] = None,
access_key_data: Optional[str] = None,
config: Optional[Dict[str, Any]] = None,
) -> None:
super().__init__(region, access_key_id, access_key_data, config)
self.client: BaseClient = boto3.client(
"secretsmanager", region_name=self.region, **self.config
)

@error_handler
def create_secret(
self,
secret_name: str,
secret_value: str,
tags: Optional[Dict[str, str]] = None,
) -> str:
"""
Returns the id (ARN) of the created secret
"""
tags_dict = []
if tags:
tags_dict = self._generate_tags_dict(tags)

response = self.client.create_secret(
Name=secret_name, SecretString=secret_value, Tags=tags_dict
)
return response["ARN"]

@error_handler
def get_secret(
self,
secret_id: str,
) -> StringSecret:
# Get secret value.
# It retrieves the current version of the secret.
val_response = self.client.get_secret_value(SecretId=secret_id)
# Get secret details. E.g tags
descr_response = self.client.describe_secret(SecretId=secret_id)

return self._convert_resp_to_secret(descr_response, val_response)

@error_handler
def delete_secret(
self,
secret_id: str,
) -> None:
# Delete secret.
self.client.delete_secret(SecretId=secret_id)

def _convert_resp_to_secret(
self, descr_resp: Dict[str, Any], val_resp: Dict[str, Any]
) -> StringSecret:
"""
Encapsulate the responses into a Secret object
"""
id = descr_resp["ARN"]
name = descr_resp["Name"]
value = val_resp.get("SecretString")
create_date = descr_resp.get("CreatedDate")
tags = convert_list_to_dict(descr_resp.get("Tags"), "Key", "Value")

return StringSecret(
id=id, name=name, value=value, create_date=create_date, tags=tags
)

def _generate_tags_dict(self, tags: Dict[str, str]) -> List[Dict[str, str]]:
# Input tag format {"tag1": "v1", "tag2", "v2", ...}
# AWS required format [{"Key": "tag1", "Value": "v1"}, ...}
new_dict = reduce(
lambda x, y: [*x, {"Key": y, "Value": tags[y]}], tags.keys(), []
)

return new_dict
54 changes: 54 additions & 0 deletions fbpcp/service/secrets_manager.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
#!/usr/bin/env python3
# Copyright (c) Meta Platforms, Inc. and affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

# pyre-strict

import abc
from typing import Dict, Optional

from fbpcp.entity.secret import StringSecret


class SecretsManagerService(abc.ABC):
@abc.abstractmethod
def create_secret(
self, secret_name: str, secret_value: str, tags: Optional[Dict[str, str]] = None
) -> str:
pass

@abc.abstractmethod
def get_secret(
self,
secret_id: str,
) -> StringSecret:
pass

@abc.abstractmethod
async def create_secret_async(
self, secret_name: str, secret_value: str, tags: Optional[Dict[str, str]] = None
) -> str:
pass

@abc.abstractmethod
async def get_secret_async(
self,
secret_id: str,
) -> StringSecret:
pass

@abc.abstractmethod
def delete_secret(
self,
secret_id: str,
) -> None:
pass

@abc.abstractmethod
async def delete_secret_async(
self,
secret_id: str,
) -> None:
pass
74 changes: 74 additions & 0 deletions fbpcp/service/secrets_manager_aws.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
#!/usr/bin/env python3
# Copyright (c) Meta Platforms, Inc. and affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

# pyre-strict

import asyncio

from typing import Any, Dict, Optional

from fbpcp.entity.secret import StringSecret

from fbpcp.gateway.secrets_manager import AWSSecretsManagerGateway
from fbpcp.service.secrets_manager import SecretsManagerService


class AWSSecretsManagerService(SecretsManagerService):
def __init__(
self,
region: str,
access_key_id: Optional[str] = None,
access_key_data: Optional[str] = None,
config: Optional[Dict[str, Any]] = None,
) -> None:
self.secret_gateway = AWSSecretsManagerGateway(
region, access_key_id, access_key_data, config
)

def create_secret(
self,
secret_name: str,
secret_value: str,
tags: Optional[Dict[str, str]] = None,
) -> str:
secret_id = self.secret_gateway.create_secret(
secret_name=secret_name, secret_value=secret_value, tags=tags
)

return secret_id

def get_secret(
self,
secret_id: str,
) -> StringSecret:
# secret id can be ARN or secret name
secret = self.secret_gateway.get_secret(secret_id=secret_id)

return secret

async def create_secret_async(
self,
secret_name: str,
secret_value: str,
tags: Optional[Dict[str, str]] = None,
) -> str:
loop = asyncio.get_running_loop()
result = await loop.run_in_executor(
None, self.create_secret, secret_name, secret_value, tags
)
return result

async def get_secret_async(self, secret_id: str) -> StringSecret:
loop = asyncio.get_running_loop()
result = await loop.run_in_executor(None, self.get_secret, secret_id)
return result

def delete_secret(self, secret_id: str) -> None:
self.secret_gateway.delete_secret(secret_id=secret_id)

async def delete_secret_async(self, secret_id: str) -> None:
loop = asyncio.get_running_loop()
await loop.run_in_executor(None, self.delete_secret, secret_id)
5 changes: 5 additions & 0 deletions scripts/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#!/usr/bin/env python3
# Copyright (c) Meta Platforms, Inc. and affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.
Loading