Skip to content

Add Python 3.14 and lint job to CI#17

Merged
jduprat merged 1 commit into
facebookresearch:mainfrom
neuralsorcerer:ci
Apr 23, 2026
Merged

Add Python 3.14 and lint job to CI#17
jduprat merged 1 commit into
facebookresearch:mainfrom
neuralsorcerer:ci

Conversation

@neuralsorcerer
Copy link
Copy Markdown
Contributor

Added Python 3.14 to the CI test matrix and a dedicated lint job in CI.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 23, 2026
@jduprat
Copy link
Copy Markdown
Contributor

jduprat commented Apr 23, 2026

There are unrelated changes in this PR. Can you separate them out?

@neuralsorcerer
Copy link
Copy Markdown
Contributor Author

neuralsorcerer commented Apr 23, 2026

There are unrelated changes in this PR. Can you separate them out?

Those changes are made to align with ruff linting (i.e. in paper_examples.py, generate_figures.py)

Comment thread docs/generate_figures.py
for c in range(K):
om, im = r // tm, r % tm
ok, ik = c // tk, c % tk
om = r // tm
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused variables and computation to align with ruff lint

Comment thread tests/paper_examples.py
"""Table 1: coordinate strides form the 2×3 matrix [e1, e0, 6e1]."""
coord_layout = lambda row, col0, col1: (col0, row + 6 * col1)

def coord_layout(row, col0, col1):
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted lambda expression to function to align with ruff lint

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that all makes sense. Thanks Soumyadip!

@jduprat jduprat merged commit e50bb31 into facebookresearch:main Apr 23, 2026
9 checks passed
@neuralsorcerer neuralsorcerer deleted the ci branch April 23, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants