Revert CONTRIBUTING.md change from D101685100#20
Merged
Conversation
Summary: Q&A request: https://fb.workplace.com/groups/osssupport/permalink/31569486946006519/ Followed previous example: D98217804 D101685100 (a difftrain import for facebookresearch/tensor-layouts) unintentionally modified the standard fbcode/github/standard/CONTRIBUTING.md by adding a project-specific "Test layout" section. D102823690 attempted to revert the entire diff but cannot land because it needs export review. This diff reverts only the CONTRIBUTING.md change. bypass-github-export-checks because people are requiring it but not running their diff trains. diff-train-skip-merge to unblock failing difftrain autosyncs from composer_model_library ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: triton landed-with-radar-review Differential Revision: D102848202
meta-cla
Bot
added
the
CLA Signed
|
@FindHao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102848202. |
There was a problem hiding this comment.
Pull request overview
Reverts an unintended project-specific addition to the repository’s standard CONTRIBUTING.md, restoring it to the generic Meta Open Source contributing guidance.
Changes:
- Removed the added “Test layout” section from
CONTRIBUTING.md.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Q&A request:
https://fb.workplace.com/groups/osssupport/permalink/31569486946006519/
Followed previous example: D98217804
D101685100 (a difftrain import for facebookresearch/tensor-layouts) unintentionally modified the standard fbcode/github/standard/CONTRIBUTING.md by adding a project-specific "Test layout" section. D102823690 attempted to revert the entire diff but cannot land because it needs export review. This diff reverts only the CONTRIBUTING.md change.
bypass-github-export-checks because people are requiring it but not running their diff trains.
diff-train-skip-merge to unblock failing difftrain autosyncs from composer_model_library
overriding_review_checks_triggers_an_audit_and_retroactive_review
Oncall Short Name: triton
landed-with-radar-review
Differential Revision: D102848202