Also build composable version of topic-converter#45
Open
MCFurry wants to merge 2 commits intofacontidavide:mainfrom
Open
Also build composable version of topic-converter#45MCFurry wants to merge 2 commits intofacontidavide:mainfrom
MCFurry wants to merge 2 commits intofacontidavide:mainfrom
Conversation
Owner
|
great, I love this |
MCFurry
force-pushed
the
feature/topic-converter-composable
branch
from
2cd7635 to
16cf35b
Compare
Author
|
I rebased on latest main to hopefully fix the CI issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this nice compressor Davide!
I also really enjoyed you ROScon talk and started integrating this into our projects.
A common usecase on our side is to rosbag most topics continuously so this compression comes in very handy.
However, for resource reasons we also like to run all lidar related nodes in a component container, hence this PR to make the topic-converter also composable.